Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the overall performance of the plugin #38

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

md5sha256
Copy link

@md5sha256 md5sha256 commented Oct 8, 2020

This PR intends to improve performance of the plugin significantly,

Changes:

  • Cached reflection calls in NBT
  • Async loading / saving of inventories
  • Cleaned up some code formatting for readability
  • Add PaperLib as a dependency, utilize async chunk loading when teleporting players where possible.

@md5sha256 md5sha256 marked this pull request as ready for review October 9, 2020 20:24
@md5sha256
Copy link
Author

I've yet to test this, will do so tomorrow; Leaving this open for "review"

@md5sha256 md5sha256 force-pushed the feature/performance branch from af7c8b2 to 8d2105a Compare October 9, 2020 20:28
Signed-off-by: Andrew Wong <[email protected]>
@Aurelien30000
Copy link
Contributor

@md5sha256 Do you allow me to includes your changes into my own fork and share them, in such a way that the jar file is downloadable and usable? Thanks!

@md5sha256
Copy link
Author

Sure, although I would advise more extensive testing. This is currently on use on a production server and there do not seem to be issues.

@Strahilchu
Copy link

Need this!

@Aurelien30000
Copy link
Contributor

Need this!

https://github.com/Aurelien30000/Inventory-Rollback/releases/tag/1.5.0 Feel free to use my own that includes this.

All the other changes I made are about code format and "logic", so don't worry ;)

@Aurelien30000
Copy link
Contributor

Sure, although I would advise more extensive testing. This is currently on use on a production server and there do not seem to be issues.

Right, two small issues fixed here (NPEs) Aurelien30000@8c5281b ^^

@Romvnly-Gaming
Copy link

Any updates on this?

@Aurelien30000
Copy link
Contributor

Not especially, go to my github page and download it from the actions page if you wanna use it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants