Fix #12796 FN: (regression) constParameter (array) (#7055)

danmar · Dec 4, 2024 · 354f0e6 · 354f0e6
1 parent 14f3620
commit 354f0e6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/astutils.cpp b/lib/astutils.cpp
@@ -2913,7 +2913,7 @@ static bool isExpressionChangedAt(const F& getExprTok,
         bool aliased = false;
         // If we can't find the expression then assume it is an alias
         auto expr = getExprTok();
-        if (!expr)
+        if (!expr && !(tok->valueType() && tok->valueType()->pointer == 0 && tok->valueType()->reference == Reference::None))
             aliased = true;
         if (!aliased)
             aliased = isAliasOf(tok, expr, &i);

diff --git a/test/testother.cpp b/test/testother.cpp
@@ -4374,6 +4374,16 @@ class TestOther : public TestFixture {
               "}\n");
         ASSERT_EQUALS("[test.cpp:2]: (style) Variable 'a' can be declared as const array\n",
                       errout_str());
+
+        check("void f(int n, int v[42]) {\n" // #12796
+              "    int j = 0;\n"
+              "    for (int i = 0; i < n; ++i) {\n"
+              "        j += 1;\n"
+              "        if (j == 1) {}\n"
+              "    }\n"
+              "}\n");
+        ASSERT_EQUALS("[test.cpp:1]: (style) Parameter 'v' can be declared as const array\n",
+                      errout_str());
     }
 
     void switchRedundantAssignmentTest() {