Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12600 FP returnDanglingLifetime with smart pointer member (regression) #6255

Closed
wants to merge 4 commits into from
Closed

Fix #12600 FP returnDanglingLifetime with smart pointer member (regression) #6255

wants to merge 4 commits into from

Conversation

chrchr-github
Copy link
Collaborator

No description provided.

@chrchr-github
Copy link
Collaborator Author

There is still a FP for

struct S {
  void *out;
};
void bar(S* s);
void foo() {
  S s[1][1];
  char arr[5];
  s[0][0].out = &arr;
  bar(s[0]);
  int len = strlen(arr);
}

@chrchr-github
Copy link
Collaborator Author

@pfultz2 any comments?

@pfultz2
Copy link
Contributor

pfultz2 commented Apr 9, 2024

I'll take a look at this. I think the any_of below might need to be updated to find the borrowed type.

@chrchr-github
Copy link
Collaborator Author

Closing in favor of #6260

@chrchr-github chrchr-github deleted the chr_Fix12600 branch April 10, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrchr-github @pfultz2