Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Attempt to enable codecov again #7034

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

danmar
Copy link
Owner

@danmar danmar commented Nov 22, 2024

No description provided.

@firewave
Copy link
Collaborator

If we want to fix the coverage it is likely you need to install the codecov app for the repository. But I mentioned this several times in the past already - see https://trac.cppcheck.net/ticket/12112.

@firewave
Copy link
Collaborator

Ah, sorry - maybe not. It might be related to the token - see #6253. But...that should/could also be fixed by using the app. More context here: #6271.

@danmar danmar marked this pull request as draft November 22, 2024 14:39
@danmar
Copy link
Owner Author

danmar commented Nov 22, 2024

I have installed the app now

@danmar
Copy link
Owner Author

danmar commented Nov 22, 2024

I don't know what to do.. do you have an idea how to fix it? Is this something you could get with higher permissions or whatever?

@danmar
Copy link
Owner Author

danmar commented Nov 22, 2024

ok I have added the CODECOV_TOKEN I think..

@firewave
Copy link
Collaborator

Updating to v4 without any other changes will fix the PRs - but it will fail after the merge: codecov/codecov-action#1359 (comment).

@firewave
Copy link
Collaborator

To fix main see codecov/codecov-action#1359 (comment). See also further comments in that ticket.

@danmar danmar marked this pull request as ready for review November 22, 2024 15:11
@danmar
Copy link
Owner Author

danmar commented Nov 22, 2024

It seems to work now?
https://app.codecov.io/gh/danmar/cppcheck/pull/7034

@danmar
Copy link
Owner Author

danmar commented Nov 22, 2024

or do you think it might fail on main still?

@danmar danmar changed the title test1 CI: Attempt to enable codecov again Nov 22, 2024
@firewave
Copy link
Collaborator

or do you think it might fail on main still?

Based on the information which is available it should not.

Please remember to restore the deleted files before merging.

@danmar danmar merged commit 64356ce into danmar:main Nov 22, 2024
49 of 50 checks passed
@danmar danmar deleted the ci-codecov branch November 22, 2024 16:47
@firewave
Copy link
Collaborator

Yay, it worked! Thanks.

Let's hope the sporadic upload failures are also fixed now since we have enabled the app. Let's give it a few days and then we can close that ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants