fix #13107: FP unusedStructMember with structured binding #7177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmar
reviewed
Jan 5, 2025
|
Please rebase - I disabled the failing test for Cygwin. |
danmar
reviewed
Jan 7, 2025
| continue; | ||
|
|
||
| const Token *tok = var->nameToken()->linkAt(-1); | ||
| if (!Token::Match(tok, "] %assign%")) |
There was a problem hiding this comment.
I would like that we handle structured bindings in range for loops also.
| @@ -1534,6 +1534,26 @@ void CheckUnusedVar::checkStructMemberUsage() | |||
| if (bailout) | |||
| continue; | |||
|
|
|||
| // Bailout if struct is used in structured binding | |||
| for (const Variable *var : symbolDatabase->variableList()) { | |||
| if (!var || !Token::Match(var->typeStartToken(), "auto &|&&| [ %varid%", var->declarationId())) | |||
There was a problem hiding this comment.
so the %varid% is for performance reasons right?
| @@ -2024,6 +2025,27 @@ class TestUnusedVar : public TestFixture { | |||
| ASSERT_EQUALS("", errout_str()); | |||
| } | |||
|
|
|||
| void structmemberStructuredBinding() { // #13107 | |||
| checkStructMemberUsage("struct S { int a, b; };\n" | |||
There was a problem hiding this comment.
can this testcase be reduced.. maybe:
"struct S { int a, b; };\n"
"void foo(const S& s) {\n"
" auto [x,y] = s;\n"
" dostuff(x,y);\n"
"}\n"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.