even more testrunner cleanups #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danmar Can this be merged? I need this to finish up that other PR. |
danmar
reviewed
Apr 11, 2022
test.cpp
Outdated
| std::vector<std::string> files; | ||
| return simplecpp::TokenList(istr,files,std::string(),outputList).stringify(); | ||
| return makeTokenList(code, files); |
There was a problem hiding this comment.
this looks dangerous. the returned TokenList will reference the local files
There was a problem hiding this comment.
You are right. I didn't think about this.
We didn't detect this in Cppcheck - I have this enabled in my IDE and it did not report anything.
There was a problem hiding this comment.
I filed https://trac.cppcheck.net/ticket/10975. It is impossible to detect the issue I introduced though since we have no idea what is done with the reference.
danmar
reviewed
Apr 13, 2022
test.cpp
Outdated
| ASSERT_EQUALS("file0,1,syntax_error,Invalid newline in raw string delimiter.\n", toString(outputList)); | ||
| outputList.clear(); | ||
|
|
||
| readfile("A = u8R\"as\n(abc)as\"", -1, &outputList); | ||
| readfile("A = u8R\"as\n(abc)as\"", &outputList); |
There was a problem hiding this comment.
indentation seems wrong on this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of all the explicit
std::istringstreamusage in the test cases so I can hopefully easily switch the implementation for the new API introduced with #244.