Skip to content

Revert "fix: use both absolute and relative header paths in header matching (#362)" #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

danmar
Copy link
Owner

@danmar danmar commented Feb 12, 2025

This reverts commit c4b6e37.

There was build errors when simplecpp was used in cppcheck:

       "D:\a\cppcheck\cppcheck\cppcheck.sln" (default target) (1) ->
       "D:\a\cppcheck\cppcheck\cli\cli.vcxproj.metaproj" (default target) (2) ->
       "D:\a\cppcheck\cppcheck\lib\cppcheck.vcxproj" (default target) (4) ->
       (ClCompile target) -> 
         D:\a\cppcheck\cppcheck\externals\simplecpp\simplecpp.cpp(152,13): error C2375: 'startsWith': redefinition; different linkage [D:\a\cppcheck\cppcheck\lib\cppcheck.vcxproj]
         D:\a\cppcheck\cppcheck\externals\simplecpp\simplecpp.cpp(2726,17): error C2440: 'return': cannot convert from 'TCHAR [260]' to 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' [D:\a\cppcheck\cppcheck\lib\cppcheck.vcxproj]
         D:\a\cppcheck\cppcheck\externals\simplecpp\simplecpp.cpp(2753,8): error C2264: 'startsWith': error in function definition or declaration; function not called [D:\a\cppcheck\cppcheck\lib\cppcheck.vcxproj]

@danmar
Copy link
Owner Author

danmar commented Feb 12, 2025

@Tal500 This reverts your fix. Please feel free to revert this and look at the error messages. Ideally we should be able to reproduce them here in the simplecpp repo also.

@danmar danmar merged commit 9ce981c into master Feb 12, 2025
32 checks passed
@danmar danmar deleted the revert branch February 12, 2025 14:37
@firewave
Copy link
Collaborator

We should be able to detect this earlier - I filed #417 about that.

Tal500 pushed a commit to Tal500/simplecpp that referenced this pull request Feb 16, 2025
@Tal500
Copy link
Contributor

Tal500 commented Feb 16, 2025

@Tal500 This reverts your fix. Please feel free to revert this and look at the error messages. Ideally we should be able to reproduce them here in the simplecpp repo also.

I think I fixed these issues by #418.
Please tell me if there are any Windows build issue that are left (my Windows resources are limited, but I tried my best).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants