Skip to content

added constness_ptr as pointer wrapper to ensure actual method constness #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

added constness_ptr as pointer wrapper to ensure actual method constness #548

wants to merge 4 commits into from

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

Taken from danmar/cppcheck#4785.

@firewave firewave mentioned this pull request Sep 24, 2025
Draft
@firewave
Copy link
Collaborator Author

I might spin out the class into a separate repo (as public domain) as this seems like something useful in general.

@firewave
Copy link
Collaborator Author

This fails to compile with GCC before 15:

simplecpp.cpp:1742:37: error: operands to ‘?:’ have different types ‘const simplecpp::constness_ptr<simplecpp::Token>’ and ‘std::nullptr_t’
 1742 |                 valueToken = argtok ? argtok->next : nullptr;
      |                              ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~

And with Visual Studio:

     6>C:\a\simplecpp\simplecpp\simplecpp.cpp(1742,54): error C2446: ':': no conversion from 'nullptr' to 'const simplecpp::constness_ptr<simplecpp::Token>' [C:\a\simplecpp\simplecpp\simplecpp_obj.vcxproj]
             C:\a\simplecpp\simplecpp\simplecpp.cpp(1742,54):
             Constructor for class 'simplecpp::constness_ptr<simplecpp::Token>' is declared 'explicit'

@firewave
avoid bugprone-exception-escape in Macro copy constructor
020f63f 
mitigated `misc-const-correctness` clang-tidy false positive

fixed `readability-math-missing-parentheses` clang-tidy warnings

.clang-tidy: disabled `readability-use-concise-preprocessor-directives`

split up Clang warnings in CMake

disabled `-Wnrvo` Clang warning

mitigated `misc-const-correctness` clang-tidy warnings

clang-tidy.yml: updated to Clang 21
@firewave
const
cc4f3f7
@firewave firewave mentioned this pull request Sep 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@firewave