get active (visible) courses only #787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks like it may hide the tab for all users - and not just the student themselves? I think there is a case where the teacher should still be able to see the report for courses that are hidden so we might still need to retain that access somehow. I think we should check inside attendance_get_user_courses_attendances to see if the currently logged in user has the viewhiddencouress capabiliity and if so, get all users courses, and if not - get only the "active" courses. |
|
closing this as it's not quite right yet, but feel free to send a new pull request if you get it sorted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a possible solution to resolve issue #772