Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap support part 2 #352

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

patviafore-kudzera
Copy link
Contributor

Use override-pull to copy the snap CMakeLists.txt over the original

This allows us to remove the SRCROOT shenanigans that we did in the last commit

Finally, use /root/parts as our target, rather than /root/project because /root/project may not exist yet at build time

Before submitting a pull request:

  • Did you fork from the development branch?
  • Are you submitting the pull request to the development branch? (not master)

Use override-pull to copy the snap CMakeLists.txt over the original

This allows us to remove the SRCROOT shenanigans that we did in the last
commit

Finally, use /root/parts as our target, rather than /root/project because
/root/project may not exist yet at build time
@dannagle dannagle merged commit 3c25036 into dannagle:development Jan 9, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants