🔇 a11y: Silence Unnecessary Icons for Screen Readers #5726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangabell
force-pushed
the
a11y/silence-icons
branch
2 times, most recently
from
63eefe8 to
742cf7c
Compare
kangabell
changed the title
danny-avila
changed the title
danny-avila
force-pushed
the
a11y/silence-icons
branch
from
742cf7c to
036d6a9
Compare
…ns for general inquiries and setup help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5723
Closes #5724
Summary
Added
aria-hidden="true"to various icons throughout the app that had no accessible name and were adding unnecessary cognitive load for screen readers. Just a little cleanup, not comprehensive.I avoided icons that change state or otherwise indicate something meaningful, which we may want to circle back on and provide intentional alt text or aria labels for those.
There were several icons that were implemented in a more complex way that I could not resolve – may create a new issue for those in the future. (And there are likely others I simply missed.)
Other Changes
Adds more detailed instructions for bug reporting
Change Type
Testing
Test Configuration:
Checklist
Please delete any irrelevant options.