Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move new pics sections to pics.o #28

Merged
merged 1 commit into from
May 17, 2024

Conversation

etdv-thevoid
Copy link
Contributor

Consolidates the additional Pics X sections needed for the updated sprites into pics.asm, so that all pokemon / trainer pics are in the same build object. Prevents changes to sprites from forcing a rebuild of multiple objects. Also improves code readability by keeping gfx together in the same source file.

@dannye
Copy link
Owner

dannye commented May 17, 2024

Thanks. The more numerous IF checks for each bank is a good idea too.

@dannye dannye merged commit 3ab31fa into dannye:master May 17, 2024
1 check passed
@etdv-thevoid etdv-thevoid deleted the pics-section-reorg branch June 5, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants