Separate exp bar and caught indicator from the rest of the gen 2 features #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some of the code dependent on condition
GEN_2_GRAPHICSdependent on a new conditionalEXP_BAR_AND_CAUGHT_INDICATOR. The motivation behind is that I wanted to have the exp bar and the caught indicator functionality while keeping the game as vanilla as possible when it comes to the graphics (while being coloured of course). It may be that I got something wrong, so I am eagerly waiting for your feedback.I tested only setting
EXP_BAR_AND_CAUGHT_INDICATORto1and the game runs fine. I did not encounter any incompatibilities with the rest of the gen 1 graphics so far. I did not test only settingGEN_2_GRAPHICSto1yet.