Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix post URL #37

Closed
wants to merge 1 commit into from
Closed

fix post URL #37

wants to merge 1 commit into from

Conversation

djosephsen
Copy link

Slack was ignoring replies from my bot (see #36). Anyway looking through the hubot code I noticed they're using a different endpoint URL for the slack-API (https://github.com/tinyspeck/hubot-slack/blob/master/src/slack.coffee#L69) . Using that URL fixes my problem.

Thanks!

-dave

@djosephsen
Copy link
Author

quasi-related: You've probably already seen this, but slack finally released their new API: http://slackhq.com/post/104688116560/rtm-api

@danryan
Copy link
Owner

danryan commented Dec 9, 2014

Hey @djosephsen, this was my goof. I realize the documentation says to use Slack's hubot integration (which is what it used originally), but I switched to using the standard incoming webhook (due to some issues we had internally with the hubot hook) without changing the docs.

The reason you saw No hooks in #36 is because the docs misled you, and thus there was no hook configured. Again, sorry about that!

I unfortunately don't think I can swap back to the hubot integration, at least for our needs. However, we could make this a configurable variable so that one could set the hook url as needed. What do you think?

@djosephsen
Copy link
Author

huh. Well FWIW my fork has been running great using the hubot integration with the proposed PR, however, I don't think I'd waste time on making it an option given slack has released this new event-based API. I think future users will probably expect RTM to be the interface. Any plans to implement an adapter for it or are you going to stick with the irc adapter?

Anyway, I'm fine closing this as wont-fix. Thanks again

-dave

@danryan
Copy link
Owner

danryan commented Dec 9, 2014

Well that's good to hear it's been working with your fixes :) It has been a few months since the hook change. Possible that whatever issues we saw had since been addressed.

I fully agree with you on crafting an adapter to support the new Slack realtime API. I'll continue supporting the current IRC gateway, but it was always a hack to work around Slack limitations. I opened #38 to track progress.

Thanks again for your contributions. I really appreciate the feedback!

@djosephsen djosephsen closed this Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants