Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jankyborders: init #838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Eveeifyeve
Copy link

@Eveeifyeve Eveeifyeve commented Feb 7, 2025

Adds the Jankyborders nix-darwin module.
Jankyborders is a popular ricing tool for styling borders on macOS.

Setup using jankyborders on nix-darwin:

image
Credit: @Lalit64 (dotfiles)

@Eveeifyeve
Copy link
Author

I will do testing in my configuration to make sure it works.

@Eveeifyeve Eveeifyeve force-pushed the jankyborders/init branch 4 times, most recently from 3ae65cb to 0b51343 Compare February 7, 2025 19:49
@Eveeifyeve
Copy link
Author

Eveeifyeve commented Feb 7, 2025

bruh... RATE LIMITED by GitHub. Welp time to touch grass for an hour, XD.

@Eveeifyeve
Copy link
Author

Doesn't work as the colors go based of AARRGGBB is that even possible in stylix @danth?

@Lalit64
Copy link
Contributor

Lalit64 commented Feb 8, 2025

@Eveeifyeve Oh my god, imagine people actually seeing your config .

Regarding the AARRGGBB, you should just be able to format the string no? I will take a look at the code in the evening and check it out.

@Eveeifyeve
Copy link
Author

@Eveeifyeve Oh my god, imagine people actually seeing your config.

Yeah I am trying to make a vertical bar on both with this styling this is based on my linux I am trying to rice my macOS so I can be one of the firsts to have 1. a clean config 2. have full ricing support for macOS and NixOS:
image

Regarding the AARRGGBB, you should just be able to format the string no? I will take a look at the code in the evening and check it out.

Well I had a look in the documentation idk if it's possible to use a base16 color? but to be honest idk, I would like to get this out so my borders look exactly like hyprlands.

@Eveeifyeve
Copy link
Author

Eveeifyeve commented Feb 8, 2025

Then I want to do a pr for sketchybar but I don't know how I would support that as it contains a command not a config file to run it, I might have to make a pr in nix-darwin to add support for the way of doing it though nix instead of args to a cli command.

@Eveeifyeve
Copy link
Author

So yeah full setup is:

  • NixOS: Hyprland & Eww
  • macOS: JankyBorders, Sketchybar and aerospace

Comment on lines 4 to 7
opacity = builtins.toString (
builtins.ceil (config.stylix.opacity.desktop * 100)
);
mkColor = color: "0x${opacity}${color}";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the AARRGGBB, you should just be able to format the string no? I will take a look at the code in the evening and check it out.

Well I had a look in the documentation idk if it's possible to use a base16 color? but to be honest idk

What exactly does not work?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it doesn't change my borders to the color, when it should.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also @Lalit64 did say he was going to test on his machine #838 (comment)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it doesn't change my borders to the color, when it should.

Does it work with a regular configuration, which is not generated by Stylix? Maybe the generated output is wrong?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eveeifyeve I have jankyborders as a nix-darwin service I think it's not working because of that. I changed the stylix input and tried to darwin-rebuild switch. I am pretty sure it should have thrown an error that their is a duplicate config option. Also there is no ~/.config/borders/bordersrc file being created. There also doesn't seem to be a home-manager module for jankyborders

Copy link
Author

@Eveeifyeve Eveeifyeve Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eveeifyeve I have jankyborders as a nix-darwin service I think it's not working because of that. I changed the stylix input and tried to darwin-rebuild switch. I am pretty sure it should have thrown an error that their is a duplicate config option. Also there is no ~/.config/borders/bordersrc file being created. There also doesn't seem to be a home-manager module for jankyborders

Hmm idk, it might have to do with AARRGGBB as said above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eveeifyeve I have jankyborders as a nix-darwin service I think it's not working because of that. I changed the stylix input and tried to darwin-rebuild switch. I am pretty sure it should have thrown an error that their is a duplicate config option. Also there is no ~/.config/borders/bordersrc file being created. There also doesn't seem to be a home-manager module for jankyborders

Hmm idk, it might have to do with AARRGGBB as said above.

Ok, I see that you're not writing to the config and just changing the styling in the darwin service. I'm pretty sure that it has to do with what @danth mentioned below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this out it might be useful.

CleanShot 2025-02-13 at 17 04 17@2x

Copy link
Author

@Eveeifyeve Eveeifyeve Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to some how convert the the colors into hexidecimal from hex value to remove #.

@Eveeifyeve Eveeifyeve force-pushed the jankyborders/init branch 2 times, most recently from f2a1c4e to c64d154 Compare February 17, 2025 04:18
@Eveeifyeve
Copy link
Author

CI is failing because I haven't rebased.

Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR ready to merge?

mkColor =
color:
"0x${
lib.strings.replaceStrings [ "#" ] [ "" ] color
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to remove #s? I thought only config.lib.stylix.colors.withHashtag.<COLOR> have the # prefix.

Otherwise, consider using lib.removePrefix.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is nececcary as janky borders requires a representation like 0xFF<COLOR> for example 0xffe2e2e3

@Eveeifyeve
Copy link
Author

Is this PR ready to merge?

Almost some issues that need to fixed and code needs to be refined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants