Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16754 build: Add support for http proxy #15404

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

htjain
Copy link

@htjain htjain commented Oct 26, 2024

Added support for http proxy in DAOS docker build infra.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@htjain htjain requested review from a team as code owners October 26, 2024 07:28
@brianjmurrell
Copy link
Contributor

@htjain Can you please resubmit your commit with a Signed-off-by:? That will be required in order to contribute your change to the project.

Added support for http proxy in DAOS docker build infra.

Signed-off-by: Hemant Jain <[email protected]>
@htjain htjain force-pushed the DAOS-16754-add-support-for-http-proxy-in-DAOS-docker-build branch from a470baf to de15a12 Compare November 13, 2024 08:07
@htjain htjain marked this pull request as draft November 13, 2024 08:09
@brianjmurrell
Copy link
Contributor

@htjain I should have also requested that your commit(s) include the pragma: Run-GHA: true. This enables running the full suite of testing. I'll push a commit to this PR to effect that but please add that to any future commits you push to this or any other PR. Thanks!

Run-GHA: true

Required-githooks: true

Signed-off-by: Brian J. Murrell <[email protected]>
Copy link

Ticket title is 'Add support for http proxy in DAOS docker build'
Status is 'Open'
Labels: 'HPE,build_infrastructure'
https://daosio.atlassian.net/browse/DAOS-16754

Not adding Run-GHA: since this is a NOOP commit just to remove a
previously added inconsequential file.  No need to waste CI time on it.

Required-githooks: true

Signed-off-by: Brian J. Murrell <[email protected]>
@brianjmurrell
Copy link
Contributor

@htjain If you think this is ready for review and landing, you should remove the draft status. People typically won't review drafts unless specifically asked (by more than just adding as a reviewer). Click this button to move it from draft to being ready for review:
image

@htjain htjain marked this pull request as ready for review November 18, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants