Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16787 utils: Suppress NLT valgrind false positives #15478

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

kjacque
Copy link
Contributor

@kjacque kjacque commented Nov 8, 2024

  • Add a suppression for Go runtime function racefuncenter.
  • Add a suppression for CGo malloc occurring during Go bootstrapping (rt0_go).

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Add a new suppression for Go runtime function racefuncenter.

Required-githooks: true

Signed-off-by: Kris Jacque <[email protected]>
@kjacque kjacque requested review from a team as code owners November 8, 2024 17:45
@kjacque kjacque self-assigned this Nov 8, 2024
@kjacque kjacque requested a review from a team November 8, 2024 17:45
Copy link

github-actions bot commented Nov 8, 2024

Ticket title is 'NLT on EL 8.8 / Valgrind.Valgrind_Memcheck - Valgrind Memcheck error detected'
Status is 'In Review'
Labels: '2.6.2tb1,2.7.101tb,NLT-testing'
https://daosio.atlassian.net/browse/DAOS-16787

@kjacque
Copy link
Contributor Author

kjacque commented Nov 8, 2024

This PR concerns an NLT suppression, so doesn't need to run extra feature tests.

frostedcmos
frostedcmos previously approved these changes Nov 8, 2024
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15478/1/testReport/

mjmac
mjmac previously approved these changes Nov 8, 2024
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15478/1/execution/node/1482/log

This seems to be in Go bootstrap code.

Required-githooks: true

Signed-off-by: Kris Jacque <[email protected]>
@kjacque kjacque dismissed stale reviews from mjmac and frostedcmos via f3a8df0 November 13, 2024 01:36
@kjacque
Copy link
Contributor Author

kjacque commented Nov 13, 2024

I've added a suppression for the issue plaguing master as well. After a little bit of research, I don't think that one has anything to do with our code, although I still don't know why it's happening in CI -- but I cannot reproduce it locally with the latest master and all the latest internal repo packages either.

@kjacque kjacque changed the title DAOS-16787 utils: Suppress NLT valgrind false positive DAOS-16787 utils: Suppress NLT valgrind false positives Nov 13, 2024
@kjacque kjacque requested a review from a team November 13, 2024 16:50
@mjmac mjmac merged commit a1b2309 into master Nov 13, 2024
59 checks passed
@mjmac mjmac deleted the kjacque/suppress-racefuncenter branch November 13, 2024 16:50
mjmac pushed a commit that referenced this pull request Nov 13, 2024
* Add a suppression for Go runtime function racefuncenter.
* Add suppression for rt0_go CGo malloc

Signed-off-by: Kris Jacque <[email protected]>
jolivier23 pushed a commit that referenced this pull request Nov 13, 2024
)

* Add a suppression for Go runtime function racefuncenter.
* Add suppression for rt0_go CGo malloc

Signed-off-by: Kris Jacque <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants