DAOS-13527 test: Support default tag assignment through Jenkinsfile #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test tags to use the functional test stages should be driven by the method through which the user has started the build. If the build has been built with parameters or started by a timer then the parameters of that build should drive the test tag selection. If the user pushes a PR then any tags defined via commit pragmas should be used followed by the any build parameter tags. Signed-off-by: Phil Henderson <[email protected]>
| tag = 'pr' | ||
| if (startedByUpstream()) { | ||
| // Default to run simple tests for dowstream builds | ||
| tag = 'always_passes' |
There was a problem hiding this comment.
Should this reflect
?TBH, I'm on the fence about whether the default tags for downstream testing belong here or above.
| if (!tag) { | ||
| // Otherwise use the default PR tag | ||
| tag = 'pr' | ||
| if (startedByUpstream()) { |
There was a problem hiding this comment.
Is this the same problem as we discussed before, in that downstream test jobs' parameters are ignored if the branch being used for the downstream job has commit pragmas on it (ignoring for now the commit we add to override the commit pragmas)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test tags to use the functional test stages should be driven by the method through which the user has started the build. If the build has been built with parameters or started by a timer then the parameters of that build should drive the test tag selection. If the user pushes a PR then any tags defined via commit pragmas should be used followed by the any build parameter tags.