-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/lemmas.k.md: rewrite TIME lemma #63
Open
asymmetric
wants to merge
6
commits into
master
Choose a base branch
from
better-constrain-time
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous form matched against any (maxUInt32 & X), including places where it shouldn't have (e.g. rules for reading from packed storage)
asymmetric
force-pushed
the
better-constrain-time
branch
from
April 13, 2020 13:33
f997def
to
029c270
Compare
d-xo
approved these changes
Apr 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm assuming CI passes. Thx for fixing my bad lemma!!! 🥰✨
asymmetric
force-pushed
the
better-constrain-time
branch
from
April 13, 2020 14:10
acbfe86
to
613d6f3
Compare
asymmetric
force-pushed
the
better-constrain-time
branch
from
April 13, 2020 15:03
ca26def
to
b4ccbd1
Compare
d-xo
reviewed
Apr 14, 2020
K doesn't seem to know that the chop can be removed in this case.
rangeUInt(224, pow224) is false, which means our rule wouldn't have applied.
asymmetric
force-pushed
the
better-constrain-time
branch
from
April 14, 2020 12:03
6ef4644
to
774d84b
Compare
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous form matched against any (maxUInt32 & X), including places
where it shouldn't have (e.g. rules for reading from packed storage).