Fix PHP warning that ControlClientTest::getMock() must match PHPUnit_…

…Framework_TestCase::getMock(...) This method was not supposed to extend any PHPUnit method and the name clash was our mistake.
dapphp · Apr 30, 2020 · 5ff0b3a · 5ff0b3a
1 parent cfb92c0
commit 5ff0b3a
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/tests/ControlClientTest.php b/tests/ControlClientTest.php
@@ -4,7 +4,7 @@
 
 class ControlClientTest extends PHPUnit_Framework_TestCase
 {
-    protected function getMock($data = null)
+    protected function getMockControlClient($data = null)
     {
         $tc = new ControlClientMock();
 
@@ -18,7 +18,7 @@ protected function getMock($data = null)
     public function testSingleLinePositiveReply()
     {
         $response = array("250 OK\r\n");
-        $tc       = $this->getMock($response);
+        $tc       = $this->getMockControlClient($response);
         $reply    = $tc->readReply();
 
         $this->assertEquals(250, $reply->getStatusCode());
@@ -36,7 +36,7 @@ public function testReadMultiReply()
             "250 OK\r\n",
         );
 
-        $tc    = $this->getMock($response);
+        $tc    = $this->getMockControlClient($response);
         $reply = $tc->readReply($cmd);
 
         $this->assertEquals(250, $reply->getStatusCode());
@@ -53,7 +53,7 @@ public function testReadMultiReply2()
             "250 OK\r\n",
         );
 
-        $tc    = $this->getMock($response);
+        $tc    = $this->getMockControlClient($response);
         $reply = $tc->readReply($cmd);
 
         $this->assertEquals(250, $reply->getStatusCode());
@@ -75,7 +75,7 @@ public function testReadLongMultiReply()
         $response[] = ".\r\n";
         $response[] = "250 OK\r\n";
 
-        $tc    = $this->getMock($response);
+        $tc    = $this->getMockControlClient($response);
         $reply = $tc->readReply($cmd);
 
         $this->assertEquals(250, $reply->getStatusCode());
@@ -95,7 +95,7 @@ public function testParseReplyWithAsyncEvent()
         $GLOBALS['async_event'] = '';
         $GLOBALS['async_data']  = '';
 
-        $tc    = $this->getMock($response);
+        $tc    = $this->getMockControlClient($response);
 
         $tc->setAsyncEventHandler(function($event, $data) {
             $GLOBALS['async_event'] = $event;
@@ -130,7 +130,7 @@ public function testAuthentication()
             "250 OK\r\n", // authenticate reply
         );
 
-        $tc = $this->getMock($response);
+        $tc = $this->getMockControlClient($response);
 
         $tc->authenticate("password");
 
@@ -151,7 +151,7 @@ public function testFailedAuthentication()
         $this->expectExceptionCode(515);
         $this->expectExceptionMessage('Authentication failed: Password did not match HashedControlPassword *or* authentication cookie.');
 
-        $tc = $this->getMock($response);
+        $tc = $this->getMockControlClient($response);
         $tc->authenticate("this is most definitely the wrong password ;)");
     }
 }