Librarization #12
Closed
Librarization #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irst step for library)
…ldFail.js from openzeppelin (copied it)
…ails even tough the name suggests it should not CRITICAL
… DSMathL can be copied and used via using exactly like in DSMath.sol contract. tests now all work as expected
|
@JohannesMayerConda this isn't a truffle project. We can't consider merging this as it would break everything downstream. |
|
I understand. Main reason why I go with this approach is that you can easily write and execute tests for this. I just write |
|
Tests can be found in https://github.com/dapphub/ds-math/blob/master/src/math.t.sol These tests are executed using dapp https://dapp.tools/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #9 here my pullrequest to change ds-math into a library. I did no other real changes on the contracts (just indentation, newer pragma version etc.). Logic should be exactly the same! I also added tests (which just call the contracts that are used for testing). I copied from ds-math/lib other repo and copied shouldFail.js from openzeppelin