Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] improve the project in several aspects #3

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[core] improve the project in several aspects #3

wants to merge 14 commits into from

Conversation

anton-karlovskiy
Copy link

@anton-karlovskiy anton-karlovskiy commented Feb 8, 2021 •
edited
Loading

Hi @gwmccubbin!

Could you please review this PR?
Thank you.

The summary of the PR is:

  • Fix reactive broken bugs in the React frontend
  • Convert class-based components to functional components with React hooks
  • Update the naming of variables, comments, and directory/file names
  • Update the UI labels with more descriptive meaning
  • Clean up for code consistency
  • Add additional scripts to package.json
  • Add a quick README.md

@oskarleonard
Copy link

@gwmccubbin what do you think of these changes? I think they look reasonable. Would also like an .nvmrc file specifying the node version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utkarsh914 utkarsh914 utkarsh914 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anton-karlovskiy @oskarleonard @utkarsh914