[fix] correct dependencies and [refactor] rewrite app.js using react hooks and [chore] clean up

[anton-karlovskiy]

No description provided.

[philippzentner]

Why are you redeclaring the const in each loop run?

[anton-karlovskiy]

Actually, there was no declaration of color variable.
Now I've fixed like so:

let color;
for (let index = 0; index < totalSupply; index++) {
  color = await contract.colors(index);
  result.push(color);
};

[KinectTheUnknown]

Why are you redeclaring the const in each loop run?

It doesn't redeclare since const is block-scoped. Therefore, each iteration is completely isolated (in terms of block-scope). const inside the for loop ensures (and make it clear that) the variable is not being reassigned during any given iteration and keeps the variable only where it is needed/used.

You can try out the following snippet for proof of concept.

const array = ["foo", "bar", "baz"];
for (let i = 0; i < array.length; i++) {
  const item = array[i];
  console.log(item);
}

It should log each item in the array and not throw an error about item already being declared (because each iteration is isolated by block-scope).

[philippzentner]

Ah, thanks. I was not aware of that. I assumed it was not optimized that way. :)