Upgrade to solidity 0.5.0 #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Update contract syntax -Fix up tests -Update migrations
Malak67
reviewed
Dec 28, 2021
|
|
||
| import "./DappToken.sol"; | ||
|
|
||
| contract DappTokenSale { | ||
| address admin; | ||
| address payable admin; |
There was a problem hiding this comment.
If you add payable here, then in constructor for admin = msg.send I get this error:
"Type address is not implicitly convertible to expected type address payable."
Malak67
reviewed
Dec 28, 2021
| require(tokenContract.transfer(admin, tokenContract.balanceOf(this))); | ||
|
|
||
| require(tokenContract.transfer(admin, tokenContract.balanceOf(address(this)))); | ||
| // require(tokenContract.transfer(admin, tokenContract.balanceOf(address(this)))); | ||
| // UPDATE: Let's not destroy the contract here | ||
| // Just transfer the balance to the admin | ||
| admin.transfer(address(this).balance); |
There was a problem hiding this comment.
I think payable should be added here:
payable(admin).transfer(address(this).balance);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Update contract syntax
-Fix up tests
-Update migrations