-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Azure Auth order to be specified via azureAuthMethods
component metadata
#3217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernd Verst <[email protected]>
/ok-to-test |
Components certification testCommit ref: 67940b3 ❌ Some certification tests failedThese tests failed:
|
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 67940b3 |
Components conformance testCommit ref: 67940b3 ✅ All conformance tests passedAll tests have reported a successful status |
ItalyPaleAle
suggested changes
Nov 9, 2023
Signed-off-by: Bernd Verst <[email protected]>
…option (dapr#3213) Signed-off-by: Bernd Verst <[email protected]>
Signed-off-by: Bernd Verst <[email protected]>
Co-authored-by: Alessandro (Ale) Segala <[email protected]> Signed-off-by: Bernd Verst <[email protected]>
Co-authored-by: Alessandro (Ale) Segala <[email protected]> Signed-off-by: Bernd Verst <[email protected]>
Signed-off-by: luigirende <[email protected]> Signed-off-by: luiren <[email protected]> Signed-off-by: Alessandro (Ale) Segala <[email protected]> Co-authored-by: luiren <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]>
Signed-off-by: Bernd Verst <[email protected]>
berndverst
force-pushed
the
azureauthorder
branch
from
November 9, 2023 20:13
508cc30
to
1c99146
Compare
Signed-off-by: Bernd Verst <[email protected]>
ItalyPaleAle
approved these changes
Nov 9, 2023
ItalyPaleAle
reviewed
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3183
Implements support for specifying the order of Azure Authentication methods to try. This allows an admin to also exclude authentication methods, or to complete disallow Azure authentication.
This is accomplished via a new global component metadata field for all Azure components
azureAuthMethods
. This field accepts a string of comma-separated values from the following list:ServicePrincipal, Certificate, WorkloadIdentity, ManagedIdentity, CLI, None
If the list contains
None
as one of the options, all Azure Auth will be disabled regardless of other options listed.If
azureAuthMethods
is empty, or omitted (default behavior), then the current default behavior is maintained:Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #3183
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: