Fix Postgres configuration store incorrectly handling metadata key in query #3693
+21
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If key is param the query always returns empty results Signed-off-by: majkio <[email protected]>
Signed-off-by: majkio <[email protected]>
majkio
changed the title
Signed-off-by: majkio <[email protected]>
Signed-off-by: majkio <[email protected]>
JoshVanL
requested changes
Mar 13, 2025
There was a problem hiding this comment.
Thanks @majkio, please can we add a certification test to cover this fix?
|
Hello @JoshVanL I've updated the code and added the test, hope its okay. Feel free to request any additional changes |
majkio
force-pushed
the
majkio-fix-postgres-param
branch
from
9ff96a5 to
f9e724c
Compare
…fication test Signed-off-by: majkio <[email protected]>
majkio
force-pushed
the
majkio-fix-postgres-param
branch
from
f9e724c to
2929367
Compare
JoshVanL
previously approved these changes
Mar 17, 2025
cicoyle
previously approved these changes
Mar 31, 2025
JoshVanL
approved these changes
Apr 29, 2025
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
buildQueryfunction of Postgres configuration store component.Metadata key is no longer passed as a parameter, fixing the always empty query result.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[3692]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: