Skip to content

state: add RavenDB support #3702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

nmalocic
Copy link

@nmalocic nmalocic commented Mar 13, 2025

Added files related to RavenDB implementation from old branch for cleaner history

Description

Added support for RavenDB as state store.
Support for Set, Get, Delete and Multi interfaces.
Added conformance and certification tests

Issue reference

Please reference the issue this PR will close: #3318

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [] Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@nmalocic nmalocic requested review from a team as code owners March 13, 2025 19:27
@elena-kolevska
Copy link
Contributor

elena-kolevska commented Mar 14, 2025

Hey @nmalocic thank you for your contribution!
Can you please sign your commits and check the failing tests?
https://github.com/dapr/components-contrib/pull/3702/checks

@daixiang0
Copy link
Member

@nmalocic could you use a more meaningful title?

@nmalocic nmalocic changed the title [3318]: RavenDB [3318]: Support RavenDB as state store Mar 14, 2025
@nmalocic nmalocic force-pushed the 3318-RavenDB-state-store-new branch from 31aa273 to 5064086 Compare March 14, 2025 09:58
@nmalocic
Copy link
Author

@elena-kolevska Commit is signed and now I see pending conformance tests, is there anything to fix before they are runned?

@daixiang0 Is title better now, should I also update description?

@daixiang0
Copy link
Member

@elena-kolevska Commit is signed and now I see pending conformance tests, is there anything to fix before they are runned?

@daixiang0 Is title better now, should I also update description?

Please remove issue number in the title, format as "state: add RavenDB support". Also update description.

@nmalocic nmalocic changed the title [3318]: Support RavenDB as state store state: add RavenDB support Mar 17, 2025
Copy link
Contributor

@elena-kolevska elena-kolevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Patrick!
There's a lint error preventing cert tests to run.
Also, I didn't see the ravendb conformance test in the executed actions, it needs to be added in there (I think in the .github/scripts/test-info.mjs file). Check this pr for reference: #3588

@nmalocic nmalocic requested a review from elena-kolevska March 18, 2025 13:13
@nmalocic nmalocic force-pushed the 3318-RavenDB-state-store-new branch from 161c4e4 to 53fef16 Compare March 20, 2025 15:18
Copy link
Contributor

@elena-kolevska elena-kolevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a few small things and also check the lint failures pls.
Great work!

ports:
- "8080:8080"
environment:
- RAVEN_LICENSE={"Id":"1bcf6b3f-cd52-488c-9aa2-c982d6e57c78","Name":"RavenDB","Keys":["CtmBDhwRJAJIDOHv+Pev+B8o4","A5l3K4n1z2FbtgHsKPl1QkQNx","LPqr9nkPEq5MUCHQZ0XkkP5BY","Czc9DkF33Y8mNFemJZl8tkGm6","DY2Q6YyYtEt/jQayDOUVUtUlY","FC4inkD4zkb3Ii2WEbyv5RRew","jzoKxeOVYXQsToAMe6xG9ABYE","DNy4wBSYoSQMqKywtLi8wJzEy","MzQVFjc4OTo7PD0+nwIfIJ8CI","CCfAiEgnwIjIJ8CJCCfAiUgnw","ImIJ8CJyCfAiggnwIpIJ8CKiC","fAisgnwIsIJ8CLSCfAi4gnwIv","IJ8CMCCfAzZAAZ8CQiBDJEQJY","htbnwRBYBhb"]}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to put this in a secret and get a license that never expires

nmalocic and others added 5 commits March 21, 2025 11:53
Co-authored-by: Elena Kolevska <[email protected]>
Signed-off-by: Nemanja Malocic <[email protected]>
Co-authored-by: Elena Kolevska <[email protected]>
Signed-off-by: Nemanja Malocic <[email protected]>
Co-authored-by: Elena Kolevska <[email protected]>
Signed-off-by: Nemanja Malocic <[email protected]>
Co-authored-by: Elena Kolevska <[email protected]>
Signed-off-by: Nemanja Malocic <[email protected]>
Copy link
Contributor

@elena-kolevska elena-kolevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and can be merged as soon as the licence key is removed from code and set as an env variable.

@cicoyle
Copy link
Contributor

cicoyle commented Mar 31, 2025

@nmalocic - mind running the linter locally and fixing the issues?

Signed-off-by: Nemanja Malocic <[email protected]>
Signed-off-by: Nemanja Malocic <[email protected]>
@nmalocic
Copy link
Author

nmalocic commented Apr 2, 2025

@yaron2 What would be next steps for this PR?

@nmalocic nmalocic requested a review from elena-kolevska April 9, 2025 10:58
@nmalocic
Copy link
Author

nmalocic commented Apr 9, 2025

@cicoyle lint is fixed, what would be next steps for this PR?

@msfussell msfussell added this to the v1.16 milestone Apr 12, 2025
@JoshVanL
Copy link
Contributor

@nmalocic please could you resolve the conflict? 🙂

@nmalocic nmalocic force-pushed the 3318-RavenDB-state-store-new branch from 61dc865 to 36315dc Compare April 29, 2025 12:18
@nmalocic
Copy link
Author

nmalocic commented May 3, 2025

@nmalocic please could you resolve the conflict? 🙂

Hi @JoshVanL is it ok now?

@JoshVanL
Copy link
Contributor

JoshVanL commented May 3, 2025

@nmalocic please could you resolve the conflict? 🙂

Hi @JoshVanL is it ok now?

Thanks, @nmalocic- let’s see what CI says
Appreciate your work on this!

@JoshVanL
Copy link
Contributor

JoshVanL commented May 3, 2025

@nmalocic I think you need to run make modify-allor equivalent I this repo.

@nmalocic
Copy link
Author

hi @JoshVanL I fixed few merges and ran modtidy. Is there a way that I can check all this checks locally?

Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RavenDB as State store
7 participants