Skip to content

fix #3680 and #3679 #3722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix #3680 and #3679 #3722

wants to merge 11 commits into from

Conversation

ThinkontrolSY
Copy link

@ThinkontrolSY ThinkontrolSY commented Apr 1, 2025

fix Cause ErrCannotWriteRecord when no tags #3679

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@ThinkontrolSY ThinkontrolSY requested review from a team as code owners April 1, 2025 01:56
@cicoyle
Copy link
Contributor

cicoyle commented Apr 1, 2025

Hey @ThinkontrolSY thanks for the PR 🎉 - mind taking a look at some of the CI failures and resolving them?

@ThinkontrolSY ThinkontrolSY force-pushed the main branch 2 times, most recently from e640bd9 to 40c8104 Compare April 15, 2025 01:33
ShenYang and others added 2 commits April 15, 2025 09:34
Signed-off-by: ShenYang <[email protected]>
Signed-off-by: Emmanuel Auffray <[email protected]>
Co-authored-by: Josh van Leeuwen <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: ShenYang <[email protected]>
Copy link
Author

@ThinkontrolSY ThinkontrolSY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this three files have been reviewed

@ThinkontrolSY ThinkontrolSY requested a review from JoshVanL May 30, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants