[pub/sub pulsar] Add suggested warning re sensitive params #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hannah Hunter <[email protected]>
msfussell
reviewed
Jun 16, 2023
| {{% alert title="Warning" color="warning" %}} | ||
| This component supports storing the `token` parameter and any other sensitive parameter and data as Kubernetes Secrets. | ||
| {{% /alert %}} | ||
|
|
There was a problem hiding this comment.
The general warning we have is this
"The above example uses secrets as plain strings. It is recommended to use a secret store for the secrets as described here."
I would use this ^^ combining this with the " storing the token parameter and any other sensitive parameter" as specific to this component
There was a problem hiding this comment.
@msfussell pushed an update - let me know if that works?
Signed-off-by: Hannah Hunter <[email protected]>
msfussell
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add warning as suggested in issue re: sensitive data/params
Issue reference
PR will close: #3250