Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip_deploy_on_missing_secrets config #3564

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

AaronCrawfis
Copy link
Collaborator

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

#3559 introduced a new build step that builds the Dapr docs outside of the Azure Static Web App step. This reconfigured the SWA step and accidentally removed skip_deploy_on_missing_secrets.

skip_deploy_on_missing_secrets is needed because when PRs are created from forked repos Actions doesn't inject the SWA token, so we want to skip deployment and proceed without a staging site.

Issue reference

@AaronCrawfis AaronCrawfis requested review from a team as code owners June 19, 2023 17:32
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-05112ff1e-3564.westus2.1.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-bay-0e9e0e81e-3564.westus2.azurestaticapps.net

@hhunter-ms hhunter-ms merged commit b85163f into v1.11 Jun 19, 2023
7 checks passed
@AaronCrawfis AaronCrawfis deleted the aacrawfi/skip-deploy-missing-secrets branch June 19, 2023 17:39
@AaronCrawfis AaronCrawfis mentioned this pull request Jun 19, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants