-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guestConfig metadata doc for wasm middleware #3632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhangchao <[email protected]>
Signed-off-by: zhangchao <[email protected]>
hhunter-ms
requested changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick review
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-wasm.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-wasm.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-wasm.md
Outdated
Show resolved
Hide resolved
@Taction - Can you take a look at these few updates? Thx |
…iddleware/middleware-wasm.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Taction <[email protected]>
…iddleware/middleware-wasm.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Taction <[email protected]>
…iddleware/middleware-wasm.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Taction <[email protected]>
Thanks for the review and the remind. Fixed. |
msfussell
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hhunter-ms
approved these changes
Aug 7, 2023
Signed-off-by: Hannah Hunter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Add guestConfig metadata doc for wasm middleware.
Issue reference
Please reference the issue this PR will close: #3617