Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note that low app health probe timeout can cause problems if response time degrades #3641

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

fabistb
Copy link
Contributor

@fabistb fabistb commented Jul 26, 2023

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Add the information that a low app health probe timeout can during high load mark an application as unhealthy if the response time degrades.

This can cause an unexpected application behavior.

Issue reference

#3623

@fabistb fabistb requested review from a team as code owners July 26, 2023 19:42
@fabistb fabistb force-pushed the low-application-helath-probe-timeout branch from 24099a3 to 845c75f Compare July 26, 2023 19:51
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit 23d46ce into dapr:v1.11 Jul 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants