Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install-dapr-cli.md #4273

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Update install-dapr-cli.md #4273

merged 2 commits into from
Jul 23, 2024

Conversation

gralin
Copy link
Contributor

@gralin gralin commented Jul 23, 2024

Add a note that Docker Desktop's advanced options section is not visible when WSL integration is enabled.

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Add a note that Docker Desktop's advanced options section is not visible when WSL integration is enabled.

Issue reference

Add a note that Docker Desktop's advanced options section is not visible when WSL integration is enabled.

Signed-off-by: Jakub Bartkowiak <[email protected]>
@gralin gralin requested review from a team as code owners July 23, 2024 08:58
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick typo fix, otherwise lgtm - thank you!

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Jakub Bartkowiak <[email protected]>
@hhunter-ms hhunter-ms merged commit 1ada47e into dapr:v1.13 Jul 23, 2024
7 checks passed
@gralin gralin deleted the patch-1 branch July 24, 2024 09:24
@yaron2 yaron2 added this to the 1.14 milestone Jul 31, 2024
@marcduiker
Copy link
Contributor

@holopin-bot @gralin Thank you!

Copy link

holopin-bot bot commented Aug 15, 2024

Congratulations @gralin, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzv96o4299720cjvm17htpzg

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants