Tweaked the observability endpoint description and examples to reflect that the protocol may not be necessary #4351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocol may or may not be necessary based on the provider used. Signed-off-by: Whit Waldo <[email protected]>
JoshVanL
approved these changes
Sep 13, 2024
|
/assign |
KrylixZA
reviewed
Sep 13, 2024
daprdocs/content/en/operations/configuration/configuration-overview.md
Outdated
Show resolved
Hide resolved
KrylixZA
reviewed
Sep 13, 2024
daprdocs/content/en/operations/configuration/configuration-overview.md
Outdated
Show resolved
Hide resolved
…hough it's not necessary on the otel endpoint. Signed-off-by: Whit Waldo <[email protected]>
hhunter-ms
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
There was feedback in Discord that when 'grpc' was used, they were unable to get the configuration to work when they specified the protocol in the endpoint for their OTEL provider. As such, I've updated the documentation to reflect that it may not be necessary so at least future developers can understand that they may need to play around with it if their provider doesn't explicitly specify this.
Thanks for calling this out @KrylixZA !
Issue reference
N/A