Skip to content

Conversation

@WhitWaldo
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Added an example for implementing streaming subscription support in .NET.

Please do not merge this until this PR has been accepted and merged

Issue reference

It won't necessarily close either, but it's associated with this PR and this issue.

@WhitWaldo WhitWaldo requested review from a team as code owners September 16, 2024 19:50
@WhitWaldo
Copy link
Contributor Author

/assign

@WhitWaldo
Copy link
Contributor Author

/assign

@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Sep 25, 2024
@WhitWaldo
Copy link
Contributor Author

Despite being marked as stale by the bot, please do not merge this until this PR has been accepted and merged, per the ask in the description.

@github-actions github-actions bot removed the stale label Sep 26, 2024
@github-actions
Copy link

github-actions bot commented Oct 1, 2024

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Oct 1, 2024
@msfussell msfussell added waiting-on-code-pr The code PR needs to be merged before the docs are updated and removed stale labels Oct 3, 2024
@WhitWaldo
Copy link
Contributor Author

WhitWaldo commented Oct 24, 2024

Blocked pending on dapr/dotnet-sdk#1380 now instead of dapr/dotnet-sdk#1346

Just kidding - blocked on dapr/dotnet-sdk#1381 instead.

@WhitWaldo
Copy link
Contributor Author

@hhunter-ms Good to go!

@hhunter-ms hhunter-ms removed the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Nov 14, 2024
@hhunter-ms hhunter-ms merged commit 3f719f2 into dapr:v1.14 Nov 14, 2024
7 checks passed
@WhitWaldo
Copy link
Contributor Author

@hhunter-ms This is my bad, but the bits for streaming subs for .NET won't come out until 1.15 and I realize I neglected to say that anywhere. Now, that's scheduled to come out in a month, but should we roll this back and commit instead to the 1.15 preview instead?

@hhunter-ms
Copy link
Contributor

@hhunter-ms This is my bad, but the bits for streaming subs for .NET won't come out until 1.15 and I realize I neglected to say that anywhere. Now, that's scheduled to come out in a month, but should we roll this back and commit instead to the 1.15 preview instead?

@WhitWaldo Ope I moved too fast haha. Yes, let's roll it back and point to 1.15 instead

@WhitWaldo
Copy link
Contributor Author

WhitWaldo commented Nov 14, 2024

@hhunter-ms If you roll it back, is it easier if I resubmit the PR targeting the 1.15 branch?

@hhunter-ms
Copy link
Contributor

@WhitWaldo I've removed from 1.14 - you can go ahead and open a new PR to 1.15! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants