Update contributing Guide #4396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hannah Hunter <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
|
Stale PR, paging all reviewers |
msfussell
reviewed
Oct 29, 2024
|
|
||
| - Save them as high-res PNG files into the [images folder](https://github.com/dapr/docs/tree/v1.11/daprdocs/static/images). | ||
| - Name your PNG files using the convention of a concept or building block so that they are grouped. | ||
| 1. Download the [Dapr Diagrams template deck](https://github.com/dapr/docs/tree/v1.14/daprdocs/static/presentations) to use the icons and colors. |
There was a problem hiding this comment.
Is there any way that we can have the URL here be dynamic, otherwise this will need to be updated on each release. If not, then can keep this for now, but it will eventually go stale.
There was a problem hiding this comment.
I am referring to the v1.14 in the URL and whether this can use the latest tag? Have we done this anywhere else?
There was a problem hiding this comment.
I don't think we have... I can do a quick search though.
msfussell
reviewed
Oct 29, 2024
| - Name your PNG files using the convention of a concept or building block so that they are grouped. | ||
| 1. Download the [Dapr Diagrams template deck](https://github.com/dapr/docs/tree/v1.14/daprdocs/static/presentations) to use the icons and colors. | ||
| 1. Add a new slide and create your diagram. | ||
| 1. Screen capture the diagram as high-res PNG file and save in the [images folder](https://github.com/dapr/docs/tree/v1.14/daprdocs/static/images). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to the contributing guide re: new diagram process
Link to quickstart contributing guide in quickstart repo
Issue reference
PR will close: #4395