Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: fix description of backoff coefficient #4402

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

famarting
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

As discussed here https://discord.com/channels/778680217417809931/1075836407156850698/1296890277033939045

the definition of the backoff coefficient for workflow retries does not adhere to the actual implementation.

Issue reference

@famarting famarting requested review from a team as code owners October 24, 2024 08:00
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@famarting - Reviewed and left a few comments

…rkflow/workflow-features-concepts.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Fabian Martinez <[email protected]>
@famarting
Copy link
Contributor Author

this is ready IMO

@hhunter-ms hhunter-ms merged commit b82a4b9 into dapr:v1.14 Oct 31, 2024
7 checks passed
@famarting famarting deleted the wf-backoff-coefficient branch November 4, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants