Removed deprecated Workflow methods and types from DaprClient and tests #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d types Signed-off-by: Whit Waldo <[email protected]>
7 tasks
|
/assign |
|
@WhitWaldo This is pr is related with the incremental source generator for actors #1334? |
|
@m3nax Nope, apologies - meant to link 1344 and accidentally put 1334 (and did it again while typing this message). |
Signed-off-by: Whit Waldo <[email protected]>
philliphoff
reviewed
Oct 11, 2024
| @@ -11,7 +11,7 @@ | |||
| // limitations under the License. | |||
| // ------------------------------------------------------------------------ | |||
|
|
|||
| namespace Dapr.Client | |||
| namespace Dapr.Workflow | |||
There was a problem hiding this comment.
Will need to mark this as a breaking change in the release notes.
There was a problem hiding this comment.
Is there somewhere this should be marked or just something I should write on a sticky note to add to the draft after the code freeze?
This was in response to #1344 which is being tracked in dapr/dapr#8008
philliphoff
previously approved these changes
Oct 11, 2024
…ality has been moved out to the Dapr.Workflow project instead. Signed-off-by: Whit Waldo <[email protected]>
This was referenced Oct 11, 2024
|
Closing in favor of #1362 which resolves merge conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the Workflow methods from the DaprClient, DaprGrpcClient and an end-to-end test as well as a few now-unused types. Also refactored the
WorkflowRuntimeStatusenum out fromDapr.Clientand intoDapr.Workflowas it has no more purpose in the former project.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1344
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: