Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create empty Grpc files on LUT build #686

Closed
wants to merge 1 commit into from

Conversation

eNeRGy164
Copy link
Contributor

Description

Create a workaround that generates an empty file if it is a Live Unit Testing build.

Issue reference

Will close: #685

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly

@rynowak
Copy link
Contributor

rynowak commented Jun 6, 2021

hi @eNeRGy164 thanks for digging into this. I've pinged the .NET gRPC maintainer to see if I can understand this better. Please sit tight a bit while I do research.

@halspang
Copy link
Contributor

halspang commented Jan 6, 2023

@eNeRGy164 - This fell off of our radar, but is it still something you'd like to see? I can see if any progress was made originally/if I can follow-up myself.

@WhitWaldo
Copy link
Contributor

@eNeRGy164 Thank you for your contribution!

I'm going to close this PR as we haven't heard anything from you in the last year and with v1.15, the shape of the solution is changing a bit. The various Dapr.* projects do not implement from the protos directly and instead reference them from Dapr.Protos, so creating the empty prototype here for testing no longer feels quite relevant. That said, if a the scenario comes up in which we wind up needing to add this to the Dapr.Protos file, I'll make sure you assign you for attribution on the PR.

@WhitWaldo WhitWaldo closed this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solution does not support Live Unit Testing in Visual Studio Enterprise
4 participants