Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Micrometer Observation support to Spring Dapr Messaging #1150

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

artur-ciocanu
Copy link
Contributor

@artur-ciocanu artur-ciocanu commented Oct 19, 2024

Description

This PR adds support for Micrometer Observation into Spring Dapr Messaging. If everything goes well we will add similar support to Spring Dapr Data. This PR is heavily inspired and is a continuation of this PR: #1126.

In this PR I didn't enable any Project Reactor Hooks for context propagation. If we want to have context data being sent to OTEL or any other Micrometer exporter, this should be controlled by spring.reactor.context-propagation=auto Spring Boot application configuration. More details can be found here: https://docs.spring.io/spring-boot/reference/actuator/observability.html.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1149

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artur-ciocanu artur-ciocanu requested review from a team as code owners October 19, 2024 09:58
@artur-ciocanu
Copy link
Contributor Author

@artursouza @cicoyle and @salaboy when you have a chance could you please take a look. Thank you!

@artur-ciocanu
Copy link
Contributor Author

@salaboy I would really appreciate if you could take this PR for "a ride" using this "spring.reactor.context-propagation=auto" Spring Boot configuration to see if traces land in Zipkin or any other tool that you played with in this PR: #1126.

Thanks in advance!

@salaboy
Copy link
Contributor

salaboy commented Oct 19, 2024

@artur-ciocanu I will check it out.. So.. this PR is following what I did on my PR, but not adding this -> https://github.com/dapr/java-sdk/pull/1126/files#diff-f86931381933e4ae24b3f860afc7618f23aecb516cea8bfd0ce627b16bf64e19R100 which is enabled by the property: spring.reactor.context-propagation=auto , am I right? are there any other significant changes?

@artur-ciocanu
Copy link
Contributor Author

@artur-ciocanu I will check it out.. So.. this PR is following what I did on my PR, but not adding this -> https://github.com/dapr/java-sdk/pull/1126/files#diff-f86931381933e4ae24b3f860afc7618f23aecb516cea8bfd0ce627b16bf64e19R100 which is enabled by the property: spring.reactor.context-propagation=auto , am I right? are there any other significant changes?

Exactly, since this is intended to be used in a Spring Boot environment, it is better to have this controlled via application configuration/properties and not enable it in the Dapr Messaging component.

@artur-ciocanu
Copy link
Contributor Author

@artursouza or @cicoyle I have made a few changes based on @salaboy suggestions. Could you please re-trigger the build, there is an IT test that failed, but it is not related to my changes.

Thank you!

@salaboy
Copy link
Contributor

salaboy commented Nov 4, 2024

@artur-ciocanu I've just tested this PR it is good to merge.. @cicoyle @artursouza

@artur-ciocanu
Copy link
Contributor Author

@artursouza and @cicoyle, since we have green light from @salaboy, could you please review, approve and merge.

Thank you!

@dapr-bot dapr-bot merged commit be05a47 into dapr:master Nov 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Micrometer Observation support to new Spring Dapr Messaging functionality
4 participants