-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Micrometer Observation support to Spring Dapr Messaging #1150
Conversation
@artursouza @cicoyle and @salaboy when you have a chance could you please take a look. Thank you! |
@artur-ciocanu I will check it out.. So.. this PR is following what I did on my PR, but not adding this -> https://github.com/dapr/java-sdk/pull/1126/files#diff-f86931381933e4ae24b3f860afc7618f23aecb516cea8bfd0ce627b16bf64e19R100 which is enabled by the property: |
Exactly, since this is intended to be used in a Spring Boot environment, it is better to have this controlled via application configuration/properties and not enable it in the Dapr Messaging component. |
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
bcb2a2e
to
a8acc97
Compare
@artursouza or @cicoyle I have made a few changes based on @salaboy suggestions. Could you please re-trigger the build, there is an IT test that failed, but it is not related to my changes. Thank you! |
@artur-ciocanu I've just tested this PR it is good to merge.. @cicoyle @artursouza |
@artursouza and @cicoyle, since we have green light from @salaboy, could you please review, approve and merge. Thank you! |
Description
This PR adds support for Micrometer Observation into Spring Dapr Messaging. If everything goes well we will add similar support to Spring Dapr Data. This PR is heavily inspired and is a continuation of this PR: #1126.
In this PR I didn't enable any Project Reactor Hooks for context propagation. If we want to have context data being sent to OTEL or any other Micrometer exporter, this should be controlled by
spring.reactor.context-propagation=auto
Spring Boot application configuration. More details can be found here: https://docs.spring.io/spring-boot/reference/actuator/observability.html.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1149
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: