Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify OTEL integration to reduce deps #1160

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

artur-ciocanu
Copy link
Contributor

Description

This PR has been created after looking at Micrometer Observation integration in PulsarTemplate here: https://github.com/spring-projects/spring-pulsar/blob/main/spring-pulsar/src/main/java/org/springframework/pulsar/core/PulsarTemplate.java#L298. Many thanks to @salaboy for pointing this out.

The main idea was to remove explicit OTEL dependency from Dapr Messaging since Micrometer Observation should be able to handle traceparent generation behind the scenes and OOTB.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artur-ciocanu artur-ciocanu requested review from a team as code owners November 5, 2024 11:03
@artur-ciocanu
Copy link
Contributor Author

artur-ciocanu commented Nov 5, 2024

@artursouza and @cicoyle this is a tiny PR to get rid of extra dependencies and ensure that we stay in the realm of Spring and Micrometer without having to bring in OTEL explicitly.

Please review and approve! Thank you 🙇

@artursouza artursouza merged commit 3dc96d7 into dapr:master Nov 5, 2024
8 checks passed
@artur-ciocanu artur-ciocanu deleted the simplify-otel branch November 6, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants