Feat standardize err msgs #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicoyle
force-pushed
the
feat-standardize-err-msgs
branch
from
049fe63 to
b420732
Compare
9 tasks
* Move dapr/concurrency to kit Does not include any code change Signed-off-by: ItalyPaleAle <[email protected]> * Fixed copyright year Signed-off-by: ItalyPaleAle <[email protected]> * Improved memory usage in error collection Signed-off-by: ItalyPaleAle <[email protected]> --------- Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]>
No code changes Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]>
* Move dapr/utils/streams to kit No code changes Signed-off-by: ItalyPaleAle <[email protected]> * 💄 Signed-off-by: ItalyPaleAle <[email protected]> * Lint Signed-off-by: ItalyPaleAle <[email protected]> --------- Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]>
* Migrate metadata decoder from components-contrib to kit Required creating the `utils` package for utils.IsTruthy too (ported from runtime) Signed-off-by: ItalyPaleAle <[email protected]> * Lint Signed-off-by: ItalyPaleAle <[email protected]> --------- Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
…t grpc status tho Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]>
* Update fswatcher to use /events/batcher Signed-off-by: joshvanl <[email protected]> * Linting Signed-off-by: joshvanl <[email protected]> * Linting Signed-off-by: joshvanl <[email protected]> * Add sleep to wait for windows fsnotify to become ready Signed-off-by: joshvanl <[email protected]> * Increase time for event to be received to 1 second Signed-off-by: joshvanl <[email protected]> --------- Signed-off-by: joshvanl <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
cicoyle
force-pushed
the
feat-standardize-err-msgs
branch
from
5e5d02f to
8ec73ae
Compare
cicoyle
requested review from
ItalyPaleAle,
JoshVanL,
elena-kolevska and
artursouza
artursouza
requested changes
Dec 14, 2023
|
LGTM, just a small change. |
Signed-off-by: Artur Souza <[email protected]>
artursouza
previously approved these changes
Dec 14, 2023
ItalyPaleAle
suggested changes
Dec 14, 2023
JoshVanL
requested changes
Dec 15, 2023
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Co-authored-by: Alessandro (Ale) Segala <[email protected]> Signed-off-by: Cassie Coyle <[email protected]>
…ad of hard coding it Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
elena-kolevska
approved these changes
Dec 18, 2023
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
ItalyPaleAle
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Standardizing error codes thorough out Dapr with this errors pkg.
NOTE: I added the gRPC err_detail type to show up in the json output in the same manner as
@typesince that is how gRPC does it and to not conflict with the fieldtypeforPreconditionFailure_Violation. Also, putting the@sign puts the type as the first field in the field output ordering.I will update the README example once I finalize my dapr runtime code in a followup PR.
Issue reference
https://github.com/dapr/proposals/blob/main/0009-BCIRS-error-handling-codes.md
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: