-
Notifications
You must be signed in to change notification settings - Fork 540
Add Jobs quickstart #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Jobs quickstart #1198
Conversation
63973bb
to
2316429
Compare
@dapr-java-sdk-reviewers @cicoyle @salaboy @artur-ciocanu This PR is also good to go. Just need approval for the workflows |
@siri-varma I agree. From a (pure) Java point of view this is ready to be merged. |
/LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @siri-varma, a couple changes for consistency
<dependency> | ||
<groupId>io.dapr</groupId> | ||
<artifactId>dapr-sdk</artifactId> | ||
<version>1.15.0-rc-5</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will wait to merge until 1.15.0 is out
jobs/java/sdk/job-scheduler/src/main/java/com/service/JobsScheduler.java
Outdated
Show resolved
Hide resolved
jobs/java/sdk/job-scheduler/src/main/java/com/service/JobsScheduler.java
Outdated
Show resolved
Hide resolved
jobs/java/sdk/job-scheduler/src/main/java/com/service/JobsScheduler.java
Outdated
Show resolved
Hide resolved
jobs/java/sdk/job-scheduler/src/main/java/com/service/JobsScheduler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
…flow.py Co-authored-by: Dzvezdana Arsovska <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
…fanin_workflow.py Co-authored-by: Dzvezdana Arsovska <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
…flow.py Co-authored-by: Dzvezdana Arsovska <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
…flow.py Co-authored-by: Dzvezdana Arsovska <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
…flow.py Co-authored-by: Dzvezdana Arsovska <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
…w.py Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
…flow.py Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: siri-varma <[email protected]>
…in state_management/javascript. Signed-off-by: tommygood <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
bddf466
to
d242992
Compare
@alicejgibbons Added the api to receive the triggers as well. |
Thanks @siri-varma looks good now. In my comments I had actually meant that we still could have used one service but had the client and the handers in the same app as per Whit's example here: https://github.com/dapr/quickstarts/blob/d1a7f7ca59291a5e744bf9a03b4db4588100d790/jobs/csharp/http/job-service/Program.cs Anyways, the more i think about it the more im not sure i love the one app solution better since it might be more likely that users will split out the job invocation in actual scenarios. So all this to say is this can be merged once we get 1.15 :) |
@alicejgibbons small request, could you please trigger the build for this PR ? Want to make sure it passes so that we will not have any suprises at the end |
Description
Add Quick start guide for Jobs API
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1115
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: