This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add package model #9
base: main
Are you sure you want to change the base?
feat: add package model #9
Changes from 1 commit
de8a049
63d9a2d
3a7f9d1
07311b9
07728da
d874997
b83f482
135d3e9
6c2b7f4
4702f75
6a71777
18f2672
4027429
68192a6
0b917ee
7569274
f514b0d
8bd0913
b7f3453
536dc71
d991974
e9de045
b0092a7
7fc96a3
cd9c2a2
32d981a
537eb95
3a8f224
ab9371c
210b7dd
a81519d
d30362f
6f24b37
d965c9c
9072775
87f1a69
b3362d0
13dc733
6d2c4e5
c3fe03a
6d8e853
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have one file per public class: https://docs.elementary.io/develop/writing-apps/code-style#classes-and-files
Also: we will have this classes on the
Vamp
namespace or in a more specific namespace?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said in another comment, since Vala namespaces have no real advantages (literally not even in terms of member accessibility), my idea was simply not to use them unless strictly necessary: for example, if we are exposing a public API or if we want to simulate static classes.