Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodezip-cli.js
has a garbled problem for multi-byte characters.node-zip/lib/nodezip-cli.js
Line 73 in a0d3962
fs.readFileSync
returns string content offilepath
decoded as'latin1'
('binary'
is alias), thenzip.file
treats its string content as "utf-8" (see jszip v2.5.0 lib/objects.js).To solve it, you remove the second argument
'binary'
. Then it will be treated as binary.