Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-99 add draft github actions CI workflow #106

Merged
merged 3 commits into from
Nov 24, 2020
Merged

GH-99 add draft github actions CI workflow #106

merged 3 commits into from
Nov 24, 2020

Conversation

davidalpert
Copy link
Contributor

@davidalpert davidalpert changed the title add draft github actions CI workflow GH-99 add draft github actions CI workflow Nov 19, 2020
@davidalpert davidalpert marked this pull request as ready for review November 19, 2020 16:42
@davidalpert
Copy link
Contributor Author

davidalpert commented Nov 19, 2020 •
edited
Loading

seems to support macos builds also:

image

This was referenced Nov 19, 2020
Closed
Merged
@davidalpert
Update ci.yml
3ec32e8 
separate the lint job from the test job so that linting can take place per go version but be limited to a single OS
@davidalpert
Copy link
Contributor Author

separated the CI job into two steps:

  • lint (runs on each supported go version but only runs on ubuntu-latest)
  • test (runs build+test on each go version and each build os)

@davidalpert
Copy link
Contributor Author

CI steps can be updated to call make after landing #103

@davidalpert davidalpert mentioned this pull request Nov 24, 2020
Closed
@darcys22 darcys22 merged commit eea1e40 into darcys22:dev Nov 24, 2020
@davidalpert davidalpert deleted the GH-99 branch November 24, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidalpert @darcys22