Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haskell! #33

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Haskell! #33

wants to merge 14 commits into from

Conversation

swizzard
Copy link

@swizzard swizzard commented Nov 9, 2016

No description provided.

@hugovk
Copy link
Contributor

hugovk commented Nov 9, 2016

Is it possible to run the tests on Travis CI? Somewhere here: https://github.com/dariusk/wordfilter/blob/master/.travis.yml#L21-L27

May need Haskell installing first.

If so, rather than using sudo apt-get install, try haskell-platform in addons: https://docs.travis-ci.com/user/installing-dependencies/#Adding-APT-Packages

Otherwise, perhaps the "mega" Trusty image has it: https://docs.travis-ci.com/user/trusty-ci-environment/

@swizzard
Copy link
Author

@hugovk I think I set the tests to run properly, but I'm not sure if they're running, nor if Haskell is properly installed on the ci server, nor how to check any of those things. I found https://docs.travis-ci.com/user/languages/haskell which makes it seem pretty easy, but I don't know very much about Travis, I'm afraid. Any help would be greatly appreciated!

@hugovk
Copy link
Contributor

hugovk commented Nov 12, 2016

@swizzard It's currently failing due to /home/travis/build.sh: line 57: cabal: command not found. cabal would need installing first and I had a quick try in this branch, but I'm not familiar with Haskell and didn't get it working. So unless you know what's missing there, perhaps it's just best just to remove it from Travis CI.

But thanks for checking!

@swizzard
Copy link
Author

swizzard commented Nov 12, 2016

@hugovk have you tried setting sudo: required before installing haskell-platform? i've tried to install cabal-install and ghc separately, and ghc fails to install with a warning about sudo. I don't personally feel comfortable doing that on someone else's server, so I'll leave it at your discretion.

@swizzard
Copy link
Author

Checking back in on this--if I remove the Haskell tests from Travis, would this branch still qualify to be merged upstream? Or should I just close this PR and let my fork live on its own?

@swizzard swizzard force-pushed the master branch 2 times, most recently from 5fe4740 to 63c1d6f Compare November 30, 2016 04:52
@hugovk
Copy link
Contributor

hugovk commented Nov 30, 2016

I don't have merge rights for this repo, but I think it'd be good to have Haskell in here and best to just remove the tests from Travis CI. Thanks for trying it out though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants