Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugin: Gift Area Planets #180

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

fromddy
Copy link
Contributor

@fromddy fromddy commented Oct 8, 2021

gift the planet(s) circled with level filter and area filter to your friends :)

@jacobrosenthal
Copy link
Contributor

We can merge both this and #178, but have you both chatted to see if theres a single plugin that could emerge. OR if that cant happen differentiate them further so theyre more different?

@fromddy
Copy link
Contributor Author

fromddy commented Oct 8, 2021

I have talked with @snowtigersoft , my plugin support different select function( select one, select area, select all), and planet level filter, snowtigersoft's plugin will support artifact +blackhole filter. So we can make something different.

@jacobrosenthal
Copy link
Contributor

Still indistinguishable to me frankly. One plugin "// Easily transfer planets to others. Select start/end coordinates to filter the planets." the other "gift the planet(s) circled with level filter and area filter to your friends :)" Those are the same plugin. Perhaps by writing your descriptions you two can figure out what is different

@fromddy
Copy link
Contributor Author

fromddy commented Oct 14, 2021

I test my plugin and snowtigersoft's plugin, actually those two plugins have two main differences in detail.

  1. for determining the receiver of planet(s), my plugin supports choosing the receiver's one planet and click button to get the address of receiver ; snowtigersoft's plugin supports choosing twitter id.
  2. for planet filter, my plugin supports planet level filter, and have three modes: set single planet, set range planet(s) (set area planet(s)) and set all planets; snowtigersoft's plugin supports showing the planet lists, plaent type filter and artifact filter.

I will make some changes in the introduction of my plugin to make it easy to distinguish, thanks for your advice.

@fromddy fromddy force-pushed the gift-area-planets branch 3 times, most recently from 106e5a5 to 4fb5020 Compare October 14, 2021 08:22
@ichub
Copy link
Member

ichub commented Mar 29, 2022

@fromddy - did you still want to get this plugin into the showcase?

@fromddy
Copy link
Contributor Author

fromddy commented Mar 30, 2022

@fromddy - did you still want to get this plugin into the showcase?

it is ok to get this plugin not into showcase :-)

title: Gift Area Planets
date: 2021-10-10T09:34:57+08:00
subtitle: Gift the planet(s) circled with level filter and support gift single planet, gift range planet(s) and gift all planet(s) :)
version: 0.6.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 0.6.4
version: 0.6.5

Update to correct version here, ☝🏽 ?

}

function setCursorMode(mode) {
console.log("Set Cursor Mode to: ", mode);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log("Set Cursor Mode to: ", mode);

nitpick, do you want to include the debug statement in this PR?

Comment on lines 17 to 18
import { html, render, useState } from
"https://unpkg.com/htm/preact/standalone.module.js";
Copy link
Contributor

@cristobal cristobal Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { html, render, useState } from
"https://unpkg.com/htm/preact/standalone.module.js";
import { html, render, useState } from
"https://unpkg.com/htm@3/preact/standalone.module.js";

Perhaps specify major preact version to use, to safeguard in case there is a preact version 4 in the future and it is not backwards compatible…

@fromddy
Copy link
Contributor Author

fromddy commented Mar 31, 2022

@cristobal thanks for all your suggestions :-)

@cristobal
Copy link
Contributor

cristobal commented Apr 7, 2022

@ichub this looks good to me after the last changes done here, can't approve this PR directly but approved imo. 🚢 it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants