-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add plugin: Gift Area Planets #180
base: master
Are you sure you want to change the base?
Conversation
We can merge both this and #178, but have you both chatted to see if theres a single plugin that could emerge. OR if that cant happen differentiate them further so theyre more different? |
I have talked with @snowtigersoft , my plugin support different select function( select one, select area, select all), and planet level filter, snowtigersoft's plugin will support artifact +blackhole filter. So we can make something different. |
Still indistinguishable to me frankly. One plugin "// Easily transfer planets to others. Select start/end coordinates to filter the planets." the other "gift the planet(s) circled with level filter and area filter to your friends :)" Those are the same plugin. Perhaps by writing your descriptions you two can figure out what is different |
I test my plugin and snowtigersoft's plugin, actually those two plugins have two main differences in detail.
I will make some changes in the introduction of my plugin to make it easy to distinguish, thanks for your advice. |
106e5a5
to
4fb5020
Compare
4731567
to
4a2a5fc
Compare
@fromddy - did you still want to get this plugin into the showcase? |
it is ok to get this plugin not into showcase :-) |
title: Gift Area Planets | ||
date: 2021-10-10T09:34:57+08:00 | ||
subtitle: Gift the planet(s) circled with level filter and support gift single planet, gift range planet(s) and gift all planet(s) :) | ||
version: 0.6.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version: 0.6.4 | |
version: 0.6.5 |
Update to correct version here, ☝🏽 ?
} | ||
|
||
function setCursorMode(mode) { | ||
console.log("Set Cursor Mode to: ", mode); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log("Set Cursor Mode to: ", mode); |
nitpick, do you want to include the debug statement in this PR?
import { html, render, useState } from | ||
"https://unpkg.com/htm/preact/standalone.module.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { html, render, useState } from | |
"https://unpkg.com/htm/preact/standalone.module.js"; | |
import { html, render, useState } from | |
"https://unpkg.com/htm@3/preact/standalone.module.js"; |
Perhaps specify major preact version to use, to safeguard in case there is a preact version 4 in the future and it is not backwards compatible…
@cristobal thanks for all your suggestions :-) |
@ichub this looks good to me after the last changes done here, can't approve this PR directly but approved imo. 🚢 it |
gift the planet(s) circled with level filter and area filter to your friends :)