Nil component #39
Open
Nil component #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkleaf
commented
Dec 17, 2024
|
@KGOH @slaughtlaught fyi |
darkleaf
commented
Dec 18, 2024
Co-authored-by: KGOH <[email protected]>
Co-authored-by: KGOH <[email protected]>
KGOH
reviewed
Dec 20, 2024
| @@ -13,6 +13,11 @@ | |||
| ;; It throws with original exception. | |||
| ;; All other possible exceptions are added as suppressed. | |||
|
|
|||
| (defn ex-map-wo-via [ex] | |||
There was a problem hiding this comment.
@darkleaf обрати внимание, мб лучше можно сделать
There was a problem hiding this comment.
@KGOH @slaughtlaught you all could simple use ex-cause
darkleaf
commented
Dec 22, 2024
| (defn- validate-component-obj! [obj variable] | ||
| (when (nil? obj) | ||
| (throw (ex-info "A component fn should not return nil" | ||
| {:variable variable})))) |
There was a problem hiding this comment.
Я не смог придумать нормальный :type.
И там ниже в var->factory-defn тоже нет type.
Если сможете придумать, будет здорово, нет - тоже ок.
darkleaf
commented
Dec 22, 2024
| (t/deftest nil-component-0-arity-test | ||
| (let [ex (try-catch (di/start `nil-component-0-arity))] | ||
| (t/is (= "An error during component build" (-> ex ex-message))) | ||
| (t/is (= "A component fn should not return nil" (-> ex ex-cause ex-message))))) |
There was a problem hiding this comment.
Should we use "must not"?
For example clojure.core contains "must" several times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #38
fixes #37