Retouch stability fixes #17917
Open
Retouch stability fixes #17917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshannoschwalm
added
bugfix
TurboGit
reviewed
Dec 1, 2024
1. In two cases OpenCL memory copy/allocation could fail without a returned error code so unnoticed and without a CPU fallback. 2, The bilateral and gaussian parts were not checked for errors so possibly unnoticed wrong results without a fallback, Maintenance: constified, dont test for deallocation is not necessary, don't report individual allocation errors as mostly not reported anyway and not informative at all. So reformatting for readability.
jenshannoschwalm
force-pushed
the
retouch_maintenance
branch
from
db25a12
to
59331eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfixes:
Maintenance:
constified, don't test for deallocation is not necessary, don't report individual allocation errors as mostly not reported anyway and not informative at all. Some reformatting for readability.